Fix test_env and test_environ to expect any locale. #24632
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
approved these changes
Jun 30, 2025
sbc100
reviewed
Jul 7, 2025
| @@ -3,5 +3,5 @@ LOGNAME=web_user | |||
| PATH=/ | |||
| PWD=/ | |||
| HOME=/home/web_user | |||
| LANG=(C|en_US).UTF-8 | |||
There was a problem hiding this comment.
The main point of these tests is to verify that setting en_US in outer environment is respected by emscripten.
If the @with_env_modify({'LANG': 'en_US.UTF-8'}) line in the test code doesn't work on windows we should probably look into why its not works and/or disable the test under windows (with a bug open to investigate why it doesn't work).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes test to pass on different locales on Windows.